Trigger post hook on Event Copy #12990
Merged
+24
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@mattwire there is a style warning. Could the hooks go in copyGeneric? |
mattwire
changed the title
mattwire
force-pushed
the
event_copy_posthook
branch
2 times, most recently
from
ce57ce1 to
395b858
Compare
mattwire
force-pushed
the
event_copy_posthook
branch
from
395b858 to
ae70f47
Compare
Yes. Much better, then it triggers on all the entities that are copied. |
mattwire
commented
Oct 29, 2018
| @@ -98,6 +98,7 @@ public function preProcess() { | |||
| $components = array('Contact', 'Contribute', 'Member', 'Event', 'Pledge', 'Case', 'Grant', 'Activity'); | |||
|
|
|||
| // FIXME: This should use a modified version of CRM_Contact_Form_Search::getModeValue but it doesn't have all the contexts | |||
| // FIXME: Or better still, use CRM_Core_DAO_AllCoreTables::getBriefName($daoName) to get the $entityShortName | |||
There was a problem hiding this comment.
Ok, this is comment is unrelated to this PR... but I was looking for a function to get the Entity shortname and I found it!
mattwire
changed the title
jitendrapurohit
approved these changes
Nov 13, 2018
| @@ -920,13 +920,11 @@ public static function &getCompleteInfo( | |||
| * @param int $id | |||
| * The event id to copy. | |||
| * boolean $afterCreate call to copy after the create function | |||
There was a problem hiding this comment.
Should we also remove this line?
|
thanks @jitendrapurohit merged. @mattwire - one comment for possible follow up above^^ |
|
@mattwire is there any related ticket to close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When creating a copy of an event via API Event.create (with a template ID) (or directly using the CRM_Event_BAO_Event::copy function - as called from ManageEvents-"Copy" in the UI) a "copy" hook is called but the expected Event.create hook is not called, despite a new event being created.
In addition the copy function (which is only called in two places) has complexities to support passing in an already copied event. This seems unnecessarily complex and this PR simplifies that so it is always responsible for creating the copied event.
Note: Copying events via the "Repeat Events" (RecurringEntity) functionality doesn't use this function... It hardcodes it's own version which should be replaced with this copy function in a future PR.
Before
CRM_Event_BAO_Event::copy()doesn't call the "create" hook when an event is created and adds unnecessary complexity by allowing an already created event to be passed in.After
CRM_Event_BAO_Event::copy()calls the "create" (post) hook when an event is created and simplifies the function so it is easier to maintain and simpler.Technical Details
The "pre" hook is still not implemented because this would require conversion from an object to a params array and changes can be made via the "post" hook if required.
Comments
This change should be NFC. The API remains the same, if extensions are calling
CRM_Event_BAO_Event::copy()directly (which is unsupported) they will need to switch to use the API. However I'm not aware of any extensions that do call that function.